Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): made v-if work again #409

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix(core): made v-if work again #409

merged 2 commits into from
Oct 2, 2023

Conversation

Tinoooo
Copy link
Contributor

@Tinoooo Tinoooo commented Sep 29, 2023

No description provided.

@Tinoooo Tinoooo self-assigned this Sep 29, 2023
@Tinoooo Tinoooo linked an issue Sep 29, 2023 that may be closed by this pull request
v-if is not working correctly #303
Closed
5 tasks
@Tinoooo Tinoooo marked this pull request as draft September 29, 2023 09:05
@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit c616941
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/65169a77b4838100082b5952
😎 Deploy Preview https://deploy-preview-409--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu
Copy link
Member

alvarosabu commented Sep 29, 2023 •
edited
Loading

Sounds promising 🔥:

  • LightHelpers
  • OrbitControls
  • Groups
  • cientos abstractions inside Groups
  • Models
  • Extend
  • Particles

Test next

  • cientos
  • postprocessing
  • nuxt

@Tinoooo Tinoooo marked this pull request as ready for review September 29, 2023 09:24
@Tinoooo Tinoooo merged commit 0d00545 into main Oct 2, 2023
8 checks passed
@Tinoooo Tinoooo deleted the fix/303-v-if-is-not-working-correctly branch October 2, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu alvarosabu approved these changes

Assignees

@Tinoooo Tinoooo

Labels
None yet
Projects
Team Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v-if is not working correctly
2 participants
@Tinoooo @alvarosabu