Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect MathRepresentation type #456

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

alexzhang1030
Copy link
Contributor

@alexzhang1030 alexzhang1030 commented Nov 30, 2023

Due to the three-types/three-ts-types#615 PR resolving the incorrect type of Color, we cannot use set(...args: number[]): any to represent the Color class.

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 7d26a3a
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/65796e11d544250008bead52
😎 Deploy Preview https://deploy-preview-456--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix @alexzhang1030

@alvarosabu alvarosabu merged commit 314b088 into Tresjs:main Dec 13, 2023
5 checks passed
@alexzhang1030 alexzhang1030 deleted the fi/tytpe branch December 13, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants