Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add new launch.json and fixed breakpoints not working #599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): add new launch.json and fixed breakpoints not working #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 11 additions & 21 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,18 @@
{
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"name": "Attach by Process ID",
"processId": "${command:PickProcess}",
"request": "attach",
"skipFiles": ["<node_internals>/**"],
"type": "node"
},
{
"name": "Attach to vite",
"port": 5174,
"request": "attach",
"skipFiles": ["<node_internals>/**"],
"type": "node"
},
{
"name": "fe-server",
"type": "node",
"type": "chrome",
"request": "launch",
"cwd": "${workspaceRoot}/packages/tres",
"runtimeExecutable": "npm",
"runtimeArgs": ["run", "dev", "--preserve-symlinks"]
"name": "Tres Debug mode",
"skipFiles": [
"<node_internals>/**",
],
"resolveSourceMapLocations": [
"!**/node_modules/**"
],
"url": "http://localhost:3000",
"webRoot": "${workspaceFolder}"
}
]
}
}
6 changes: 6 additions & 0 deletions playground/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,10 @@ export default defineConfig({
},
dedupe: ['three'],
},
server: {
hmr: {
overlay: true,
},
port: 3000,
},
})
14 changes: 13 additions & 1 deletion src/composables/useSizes/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,19 @@ export default function useSizes(
) {
const reactiveSize = toValue(windowSize)
? useWindowSize()
: useElementSize(computed(() => toValue(canvas).parentElement))
: useElementSize(
computed(
() => toValue(canvas).parentElement,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ThimoDEV why is this change needed?

Copy link
Contributor Author

@ThimoDEV ThimoDEV Mar 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alvarosabu There is an issue when the TresCanvas uses the parent element width and height.

The usElementSize composable from VueUse loses its reactivity I assume which causes the TresCanvas width and height to be 0.

This issue occurs when you hit a breakpoint and continue debugging after. When you use the useWindowSize prop this doesn't happen.

This fixes that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThimoDEV would be possible to have this change in a separate PR, is a little bit confusing to understand the scope of this one.

),
{
width:
toValue(canvas).parentElement
?.clientWidth ?? 0,
height:
toValue(canvas).parentElement
?.clientHeight ?? 0,
},
)

const debouncedReactiveWidth = readonly(refDebounced(reactiveSize.width, debounceMs))
const debouncedReactiveHeight = readonly(refDebounced(reactiveSize.height, debounceMs))
Expand Down
2 changes: 1 addition & 1 deletion vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ console.log(`${lightGreen('▲')} ${gray('■')} ${yellow('●')} ${bold('Tres')
// https://vitejs.dev/config/
export default defineConfig({
server: {
port: 5174,
port: 3000,
},
plugins: [
vue({
Expand Down