-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: coverage setup #837
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alvarosabu ,
Thanks for looking into this.
For me, after adding the changes here, no tests run.
I've appended changes to vite.config.ts
that work for me locally.
Do they work for you?
@@ -44,9 +44,13 @@ export default defineConfig({ | |||
Inspect(), | |||
], | |||
test: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the setup in this PR, 0 tests are run after pnpm test:ui
.
Tests run using the following config, which also excludes playground
, docs
and **/sponsorkit**/**
from coverage:
import { coverageConfigDefaults } from 'vitest/config'
test: {
environment: 'jsdom',
globals: true,
coverage: {
provider: 'v8',
exclude: [
...coverageConfigDefaults.exclude,
'playground/**',
'docs/**',
'**/sponsorkit**/**',
],
},
},
Taken from here: Vitest coverage.exclude docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andretchen0 for me they work, but I updated the config with your suggestion
commit: |
Hi @andretchen0 I added your suggestion, is it good to merge? |
No description provided.