Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(useRenderer): add rendererPresets import #839

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andretchen0
Copy link
Contributor

@andretchen0 andretchen0 commented Sep 23, 2024

Problem

This demo (current main) throws an error: http://localhost:5173/events/fps-drops-repro

Error message in the browser (latest FF):

Uncaught (in promise) ReferenceError: rendererPresets is not defined

To reproduce

  • git checkout main; git pull
  • pnpm dev
  • In the browser, navigate to http://localhost:5173/events/fps-drops-repro
  • Open browser console

First commit exhibiting the error

commit 2ffb498851913658a456a4c2e7ea56d726483413 (HEAD)

Source of the error

--- a/src/composables/useRenderer/index.ts
+++ b/src/composables/useRenderer/index.ts
@@ -19,7 +19,6 @@ import { get, merge, set, setPixelRatio } from '../../utils'
 
 import { normalizeColor } from '../../utils/normalize'
 import { useLogger } from '../useLogger'
-import { rendererPresets } from './const'

Solution

Revert removal of

import { rendererPresets } from './const'

Meta

Discussed on Discord.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit aeb7ea4
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/66f19381e54d150008cab768
😎 Deploy Preview https://deploy-preview-839--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0 andretchen0 marked this pull request as ready for review September 23, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant