Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node16 types #885

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: node16 types #885

wants to merge 2 commits into from

Conversation

userquin
Copy link
Member

@userquin userquin commented Dec 19, 2024

Check changes here https://github.com/Tresjs/tres/pull/885/files#diff-5fd41963f486d1796606e250bceaafc58a425d5b924c22f98dafaae17de208d3R26 , just removed some error there (the option can be undefined)

With this PR applying same strategy used here Tresjs/post-processing#152:

image

@userquin userquin requested a review from alvarosabu as a code owner December 19, 2024 22:52
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit e8954c9
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/6764ab544f490a0008e0e3b0
😎 Deploy Preview https://deploy-preview-885--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/core@885

commit: e8954c9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant