Renamed ExampleVersionInfoStrategy member function to be consistent (#…

…600) There were mixed use cases of 'targetTopic' or 'topicTarget', this renames all cases to use 'targetTopic' approach.
TriBITSPub · Feb 13, 2024 · f56356a · f56356a
1 parent eb6f87e
commit f56356a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/tribits/ci_support/CDashAnalyzeReportRandomFailures.py b/tribits/ci_support/CDashAnalyzeReportRandomFailures.py
@@ -174,8 +174,7 @@ def runDriver(self):
           alwaysUseCacheFileIfExists=True)['configure']['output']
 
         nonpassingSha1Pairs.add(
-          self.versionInfoStrategy.getTopicTargetSha1s(buildConfigOutput))
-        # nonpassingSha1Pairs.add(getTopicTargetSha1s(buildConfigOutput))
+          self.versionInfoStrategy.getTargetTopicSha1s(buildConfigOutput))
 
       print("\n  Test history failing sha1s: "+str(nonpassingSha1Pairs))
 
@@ -191,7 +190,7 @@ def runDriver(self):
           alwaysUseCacheFileIfExists=True)['configure']['output']
 
         passingSha1Pair = \
-          self.versionInfoStrategy.getTopicTargetSha1s(buildConfigOutput)
+          self.versionInfoStrategy.getTargetTopicSha1s(buildConfigOutput)
 
         if self.versionInfoStrategy.checkTargetTopicRandomFailure(passingSha1Pair, nonpassingSha1Pairs):
           print("\n  Found passing sha1 pair, " + str(passingSha1Pair)+\

diff --git a/tribits/ci_support/example_cdash_analyze_and_report_random_failures.py b/tribits/ci_support/example_cdash_analyze_and_report_random_failures.py
@@ -18,7 +18,7 @@ def main():
 
 class ExampleVersionInfoStrategy:
 
-  def getTopicTargetSha1s(self, buildData):
+  def getTargetTopicSha1s(self, buildData):
     pattern = r"Parent [12]:\n\s+(\w+)"
     matchedList = regex.findall(pattern, buildData)