Skip to content

Scripts/BloodFurnace: Update Broggok #31097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2025
Merged

Scripts/BloodFurnace: Update Broggok #31097

merged 3 commits into from
Jul 12, 2025

Conversation

offl
Copy link
Contributor

@offl offl commented Jun 23, 2025 •
edited
Loading

Changes proposed:

  • use missing text
  • despawn InCombat trigger by spell
  • add missing waypoints
  • add events to activate and prepare Broggok
  • codestyle changes

Issues addressed:

none

Tests performed:

builds, tested in-game

Nyr97
Nyr97 reviewed Jun 24, 2025
View reviewed changes
src/server/scripts/Outland/HellfireCitadel/BloodFurnace/boss_broggok.cpp
{
switch (eventId)
if (!UpdateVictim())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of this, why not using a different EventMap for non-combat specific events?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really matter for me

@Shauren Shauren merged commit 44a7b29 into TrinityCore:3.3.5 Jul 12, 2025
5 checks passed
@offl offl deleted the BloodFurnaceBroggok branch July 12, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyr97 Nyr97 Nyr97 left review comments

Assignees
No one assigned
Labels
Branch-3.3.5a
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@offl @Nyr97 @Shauren