Skip to content

chore(#26636): extend logging for GetClosestGraveyard() (#1) #31194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 3.3.5
Choose a base branch
from

Conversation

stdNullPtr
Copy link

@stdNullPtr stdNullPtr commented Aug 4, 2025

Changes proposed:
Extend logging in the GetClosestGraveyard () function to include player GUID for traceability.

Issues addressed:

Closes #26636

Tests performed:

Builds, tested in game.
image

@stdNullPtr stdNullPtr changed the title chore(#26636): extend logging for GetClosestGraveyard() (#1) chore(#26636): extend logging for GetClosestGraveyard() Aug 4, 2025
@stdNullPtr stdNullPtr changed the title chore(#26636): extend logging for GetClosestGraveyard() chore(#26636): extend logging for GetClosestGraveyard() (#1) Aug 4, 2025
@stdNullPtr stdNullPtr requested a review from Shauren August 4, 2025 23:10
@CraftedRO
Copy link
Contributor

while player guid is good, I think @Aokromes probably reffers to name of that player (if that's possible).

@stdNullPtr
Copy link
Author

while player guid is good, I think @Aokromes probably reffers to name of that player (if that's possible).

@CraftedRO I was thinking about it, but this will produce an invalid log message if the player is renamed right? You will have to do extra work if you are going through old logs, to track any renames to follow the path to the real player. The guid provides proper traceability in my opinion.

@Aokromes
Copy link
Member

Aokromes commented Aug 5, 2025

well, it's not like people renames a lot xd also, if name not found guid can be search.

@stdNullPtr
Copy link
Author

@Aokromes up to you guys, would you like me to log only name? Or GUID + name?

@Aokromes
Copy link
Member

Aokromes commented Aug 5, 2025

imho both.

@stdNullPtr
Copy link
Author

stdNullPtr commented Aug 5, 2025

imho both.

Done, this should be ok:

image

ZoneId not found for map 571 coords (-1810.8016, -4850.331, -1.839498), player name: (Ludnica) player GUID: (GUID Full: 0x0000000000000001 Type: Player Low: 1)

It's my first contribution so don't hesitate to request as much changes as needed, even for little things.

Edit: I forgot to pass the GUID as const ref as well... I will adjust in a few days, don't have access to PC for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants