-
Notifications
You must be signed in to change notification settings - Fork 6.2k
chore(#26636): extend logging for GetClosestGraveyard() (#1) #31194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.3.5
Are you sure you want to change the base?
Conversation
while player guid is good, I think @Aokromes probably reffers to name of that player (if that's possible). |
@CraftedRO I was thinking about it, but this will produce an invalid log message if the player is renamed right? You will have to do extra work if you are going through old logs, to track any renames to follow the path to the real player. The guid provides proper traceability in my opinion. |
well, it's not like people renames a lot xd also, if name not found guid can be search. |
@Aokromes up to you guys, would you like me to log only name? Or GUID + name? |
imho both. |
* chore(TrinityCore#26636): extend logging for GetClosestGraveyard() * chore: improve logging
Changes proposed:
Extend logging in the GetClosestGraveyard () function to include player GUID for traceability.
Issues addressed:
Closes #26636
Tests performed:
Builds, tested in game.
