Skip to content

Commit

Permalink
Fix small nits (#1150)
Browse files Browse the repository at this point in the history
  • Loading branch information
SUPERCILEX authored Nov 12, 2024
1 parent c33d4d5 commit 913245c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ play {
}
```

> Note: Currently [Service Account impersonation](https://cloud.google.com/docs/authentication/use-service-account-impersonation)
is only supported when using [Application Default Credentials](https://cloud.google.com/docs/authentication/provide-credentials-adc)
> Note: Currently, [Service Account impersonation](https://cloud.google.com/docs/authentication/use-service-account-impersonation)
is only supported when using [Application Default Credentials](https://cloud.google.com/docs/authentication/provide-credentials-adc).

## Task organization

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ abstract class PlayPublisherExtension @Inject constructor(
abstract val useApplicationDefaultCredentials: Property<Boolean>

/**
* Specify the Service Account to impersonate
* Specify the Service Account to impersonate.
*/
@get:Optional
@get:Input
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ internal abstract class PlayApiService @Inject constructor(
}

if (useAppDefaultCreds) {
PlayPublisher(parameters.appId.get(), parameters.impersonateServiceAccount.getOrNull())
PlayPublisher(parameters.appId.get(), parameters.impersonateServiceAccount.orNull)
} else {
credentialStream().use {
PlayPublisher(it, parameters.appId.get())
Expand Down

0 comments on commit 913245c

Please sign in to comment.