Copy release notes from previous release also when it's a staged rollout #1105
Conversation
|
Can you confirm the scenarios you've tested? I'm specifically interested in making sure release notes from past releases are still used if there are none in staging. |
| @@ -71,8 +71,6 @@ internal class DefaultTrackManager( | |||
| createDefaultTrack(config) | |||
| } | |||
|
|
|||
| track.maybeCopyChangelogFromPreviousRelease(config.trackName) | |||
There was a problem hiding this comment.
Dumb question cuz I don't remember how anything works, but why was this removed?
There was a problem hiding this comment.
Instead of calling Track.maybeCopyChangelogFromPreviousRelease we now call TrackRelease.maybeCopyChangelogFromPreviousRelease in places where we create a TrackRelease. So this functionality is still there, just in different places.
I've primarily relied on |
|
Alright sounds good, thanks! A snapshot build will be published in a bit. If you can make sure everything works with that build, I'd appreciate it. |
|
Great, thanks!
Sure. We'll run a release on Monday. I'll let you know how it goes 👍 |
|
@SUPERCILEX , we've switched to the snapshot version and all works great. The release notes were copied from our previous releases 😊 |
|
Sweet, fired off a release! |
This PR updates the logic related to reusing release notes.
Previously GPP was reusing the latest release notes only in case of a full rollout. Now GPP will reuse the latest release notes also when it's a staged rollout release.
Discussed here: #763 (comment)
✅ Tests pass
✅ Checked with real project
✅ Documentation updated