Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/arohanrachel/our impact #16

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Feature/arohanrachel/our impact #16

merged 7 commits into from
Feb 20, 2024

Conversation

arohanmittalUCSD
Copy link
Contributor

Tracking Info

Resolves #9

Changes

  • Created reusable background component taking in a single variable (imageUrl)
  • Created reusable white card component taking in four variables (title, description, varticalPosition, imageUrl)
  • Built the our-impact page in 'page.tsx' using the aforementioned reusable components

Testing

  • As this is a fully frontend issue, we visually confirmed the changes with the Figma

Confirmation of Change

4flot1
4flot2

@jennymar jennymar requested a review from syz16 February 8, 2024 05:59
syz16
syz16 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@syz16 syz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

jennymar
jennymar approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@jennymar jennymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I fixed some of the CSS and fonts as well as the structure of the files so that all the components are in the components directory and there is a page.tsx for /impact. Great work!

@jennymar jennymar merged commit 27f66b6 into main Feb 20, 2024
2 checks passed
@jennymar jennymar deleted the feature/arohanrachel/our-impact branch February 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syz16 syz16 syz16 approved these changes

@jennymar jennymar jennymar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Our Impact Page
3 participants
@arohanmittalUCSD @jennymar @syz16