Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kevinsophia/newsletter creator #42

Merged
merged 7 commits into from
May 16, 2024

Conversation

kevindo0720
Copy link
Contributor

Tracking Info

Resolves #

Changes

Implemented newsletter creator page

  • TODO

Testing

  • TODO

Confirmation of Change

TODO

@kevindo0720 kevindo0720 requested a review from jennymar as a code owner May 10, 2024 01:18
@jennymar jennymar requested a review from katelynpdn May 13, 2024 01:39
Copy link
Collaborator

@jennymar jennymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I changed the newsletter schema to filter archive by the date year and the content field is now a string instead of an array. I streamlined newsletter creator feature to just 1 page (the toggle simply switches the info in the table). Also, I refactored the warning components down to 1 WarningModule component that can be reused. Great work yall!!

Copy link
Member

@katelynpdn katelynpdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Only minor things would be a Date Validator and selecting a previously selected row. Looks great!

@jennymar jennymar merged commit 3d95638 into main May 16, 2024
2 checks passed
@jennymar jennymar deleted the feature/kevinsophia/newsletter-creator branch May 16, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants