General principles page #10
Conversation
…d bullet point component under components folder
Anthonyp0329
requested review from
a team,
sydneywb and
LillianHo5
and removed request for
a team
There was a problem hiding this comment.
Looks awesome, great work guys, especially with making the bullet point component. Just a few changes before this is ready to merge - make sure to put the styles into a separate file for each component, so BulletPointStyles, generalPrinciplesStyles, etc. Also, remove any changes to App.tsx for now. Then, should be good to go! Thanks!
Anthonyp0329
requested review from
a team,
shreyagupta112,
meganleongg and
eshaan-s18
and removed request for
sydneywb,
a team,
shreyagupta112 and
meganleongg
There was a problem hiding this comment.
This looks good to me! Aside from what Anthony mentioned, one thing I noticed was this error message showing up when running the IOS/Android emulators:
ERROR fontFamily "Roboto" is not a system font and has not been loaded through Font.loadAsync.
- If you intended to use a system font, make sure you typed the name correctly and that it is supported by your device operating system.
- If this is a custom font, be sure to load it with Font.loadAsync.
I also had this error with my task, and I thought that this thread and docs were helpful: https://stackoverflow.com/questions/57066075/console-error-fontfamily-roboto-medium-is-not-a-system-font-and-has-not-been, https://docs.expo.dev/develop/user-interface/fonts/#using-fontloadasync-instead-of-the-usefonts-hook.
Tracking Info
Resolves #5
Changes
Created General Principles and Emergency Care pages, created bullet point component that is used in a lot of other pages with the same format at General Principles (such as Emergency Care), used nested list view for multiple subpoints
Testing
Checked the page on iOS device and Android virtual device, both of which were different screen sizes too, worked fine in all cases.
Confirmation of Change