Global Search Page #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthonyp0329
requested review from
a team,
PiXlRAM and
pratyush1718
and removed request for
a team
PiXlRAM
approved these changes
Feb 10, 2024
Anthonyp0329
requested changes
Feb 11, 2024
| @@ -0,0 +1,66 @@ | |||
| import { useState } from "react"; | |||
| import { FlatList, Text, TextInput, View } from "react-native"; | |||
| import Icon from "react-native-vector-icons/FontAwesome"; | |||
There was a problem hiding this comment.
This import gave me an error, but looks like the native vector icons package should be added in the general principles pr, so should be ok
| const [query, setQuery] = useState(""); | ||
| const [filteredDocuments, setFilteredDocuments] = useState<Document[]>([]); | ||
|
|
||
| const handleSearch = (text: string) => { |
There was a problem hiding this comment.
For the future, maybe extract the handleSearch functionality to a separate file, as this will gain complexity when having to search through device storage
…that partially match and tier the documents highest to lowest from most to least similar to the search query. highlight in blue parts of titles that match search query
… titles correctly
Anthonyp0329
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #12
Changes
Created Global Search page, added frontend for search bar and search results (with functioning filtering), hardcoded array of documents to filter from.
Testing
Checked the page on iOS device and Android virtual device, both of which were different screen sizes too, worked fine in all cases. Tested filtering for the search bar on different words/chars.
Confirmation of Change