-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewall #31
Conversation
…e, made view all page with scrolling and card views that dynamically renders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking awesome!!! Great work! Make sure to resolve that issue that pops up, the "no two children" one, as I'm seeing this when testing. Also, resolve linter errors, but should be great to merge after this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visit the preview URL for this PR (updated for commit a40ea13): https://sideline-sidekick-app--pr31-viewall-jrhzv2gd.web.app (expires Tue, 07 May 2024 02:01:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c79d7b8d45dd65a5ed497bfab058d62b30d420cc |
Tracking Info
Resolves #19
Changes
Made view all page, made pressable card views, routed from home page to view all page
Testing
Checked on ios and android.
Confirmation of Change
After clicking on card with no content in card:
After clicking on card with content in card: