Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categories page #44

Merged
merged 103 commits into from
Jun 4, 2024
Merged

Categories page #44

merged 103 commits into from
Jun 4, 2024

Conversation

EdwardLinS
Copy link
Contributor

@EdwardLinS EdwardLinS commented May 14, 2024 •
edited by LillianHo5
Loading

Tracking Info

Resolves #36

Changes

  • Added the emergency and general principle category pages to display all categories under each
  • Added the all pages page to show all pages and which category they belong to
  • Allow deletion of categories and pages
  • Create a toast to confirm the deletion of categories

Testing

  • Tested fetching each category
  • Tested fetching each page
  • Testing deleting pages and categories
  • Changed the size of the window to test responsiveness

Confirmation of Change

image
image
image
image

EdwardLinS and others added 24 commits April 27, 2024 11:04
@EdwardLinS
Add category route functions to connect API to page later
9f24de4
@EdwardLinS
Allow for fetching and displaying by category and page
bc24de0
@LillianHo5
Move files into src/app and set up for styling
a710a3b
@LillianHo5
Initial styling for Principles view
bfdf0a1
@LillianHo5
Add styling to All view
8a87cf6
@LillianHo5
Add styling to General Principles view
3ef5b0a
@EdwardLinS
Change styling to match figma colors and style emergency and all page…
8c026a6 
…s page
@EdwardLinS
Merge
5740543
@EdwardLinS
Fix coloring style
fbc284d
@EdwardLinS
Finish all pages elements
ee69a0a
@EdwardLinS
Update icons to svg for better resolution
2a741f4
@EdwardLinS
Add basic responsiveness
58a86b4
@EdwardLinS
Add more responsiveness for the page table
ceb2ae6
@EdwardLinS
Fix table responsiveness bug
05ee4ff
@LillianHo5
Update styling for visibility select for both containers
5c6e5bc
@LillianHo5
Create delete category popup
35441ec
@LillianHo5
Implement delete category functionality
113134c
@LillianHo5
Add initial implementation of toast for successful deletion
890967b
@LillianHo5
Update responsiveness of delete popup
b9c88eb
@eshaan-s18
initial commit
45ce154
@r800360
Center Test text
091d7b6
@eshaan-s18
Added frontend
5ff75bf
@LillianHo5
Fix close toast bug and add initial implementation for making general…
a4ff9dd 
… principles responsive
@EdwardLinS
Cleaned unneed files and made responsiveness fixes
ad8e559
@EdwardLinS EdwardLinS linked an issue May 14, 2024 that may be closed by this pull request
Categories Page Component #36
Closed
@Anthonyp0329 Anthonyp0329 requested review from a team and removed request for a team May 14, 2024 16:41
@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 119795e):

https://sideline-sidekick-app--pr44-categories-page-l0v4l0i0.web.app

(expires Tue, 11 Jun 2024 01:33:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c79d7b8d45dd65a5ed497bfab058d62b30d420cc

r800360
r800360 approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@r800360 r800360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edward and Lillian, nice job fixing the delete button on the all-page as well as all of those nasty linter errors! This code looks good to merge to me.

eshaan-s18
eshaan-s18 approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@eshaan-s18 eshaan-s18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great job!

Anthonyp0329
Anthonyp0329 approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@Anthonyp0329 Anthonyp0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and ready to merge! Awesome work!

@Anthonyp0329 Anthonyp0329 merged commit c3f62fa into main Jun 4, 2024
5 checks passed
@Anthonyp0329 Anthonyp0329 deleted the categories-page branch June 4, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anthonyp0329 Anthonyp0329 Anthonyp0329 approved these changes

@r800360 r800360 r800360 approved these changes

@eshaan-s18 eshaan-s18 eshaan-s18 approved these changes

Assignees

@EdwardLinS EdwardLinS

@LillianHo5 LillianHo5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Categories Page Component
5 participants
@EdwardLinS @eshaan-s18 @r800360 @Anthonyp0329 @LillianHo5