Feature/anvitaa22/127 student attendance display #128
Conversation
There was a problem hiding this comment.
Great work, but some changes i noticed
- The time should have a "-" in between the start and end time
- The time is not being parsed correctly -> for example, i made a class from 12-1PM, but it shows up as 8-9PM. I think it is probably a UTC conversion issue, so make sure to check that you display the time as local time
- The buttons on the student page should not have a pointer for the cursor since they cannot be clicked
- There is a test case that is failing to pass
thank you :)
| const studentAttendance = await api.getSingleUserAttendanceFromSessionID(user.id, sessionId, classId); | ||
| setStudentAttendance(studentAttendance); |
There was a problem hiding this comment.
since parents should be able to access this page for their students, how about we pass an id in via an optional prop. If its set, we get the information of that user, else we get it from the logged in user id
| if (user.role == "Teacher" || user.role == "Admin"){ | ||
| const attendances = await api.getAttendanceFromSessionID(sessionId, classId); | ||
| setAttendance(attendances); | ||
| } | ||
| else{ |
There was a problem hiding this comment.
commenting for why we are splitting this up based on roles
There was a problem hiding this comment.
The Attendance objects returned are different. The Teachers and Admin get a list of Attendance objects whereas a student gets a list of SingleUserAttendance objects
lib/database/classes.ts
Outdated
| "SELECT e.name, cl.event_information_id, cl.min_level, cl.max_level, cl.rrstring, cl.start_time, cl.end_time, cl.language, u.id as user_id, u.first_name, u.last_name " + | ||
| "FROM (((event_information e INNER JOIN classes cl ON e.id = cl.event_information_id) " + | ||
| "INNER JOIN commitments ON commitments.event_information_id = e.id) " + | ||
| " INNER JOIN users u ON commitments.user_id = u.id) WHERE role = 'Teacher'", | ||
| " INNER JOIN users u ON commitments.user_id = u.id)", |
There was a problem hiding this comment.
@Anshul-Birla need to change this for the frontend view of the manage classes view
There was a problem hiding this comment.
Not sure what to do for this
There was a problem hiding this comment.
its for me dont worry
lib/database/classes.ts
Outdated
| "SELECT e.name, cl.event_information_id, cl.min_level, cl.max_level, cl.rrstring, cl.start_time, cl.end_time, cl.language, u.id as user_id, u.first_name, u.last_name " + | ||
| "FROM (((event_information e INNER JOIN classes cl ON e.id = cl.event_information_id) " + | ||
| "INNER JOIN commitments ON commitments.event_information_id = e.id) " + | ||
| " INNER JOIN users u ON commitments.user_id = u.id) WHERE role = 'Teacher'", | ||
| " INNER JOIN users u ON commitments.user_id = u.id)", |
There was a problem hiding this comment.
its for me dont worry
Anshul-Birla
deleted the
feature/anvitaa22/127-student-attendance-display
branch
Administrative Info
Make sure your branch name conforms to:
<feature/staging/hotfix/...>/[username]/[Github Issue]-[3-4 word description separated by dashes].What issue(s) does this branch close? #127
Changes
What changes did you make?
Testing
How did you confirm your changes worked?
Confirmation of Change
Run app on localhost. Make student, teacher and admin account. Make class with student and teacher. View Student attendance page after clicking on manage class in student view.