Create parent attendance display #130 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anshul-Birla
requested changes
Feb 17, 2023
Comment on lines
88
to
95
| {RRule.fromString(Class.rrstring).toText().charAt(0).toUpperCase() + | ||
| RRule.fromString(Class.rrstring).toText().slice(1) + | ||
| ", start " + | ||
| monthNames[RRule.fromString(Class.rrstring).options.dtstart.getMonth()] + | ||
| " " + | ||
| RRule.fromString(Class.rrstring).options.dtstart.getDate() + | ||
| ", " + | ||
| RRule.fromString(Class.rrstring).options.dtstart.getFullYear()} |
There was a problem hiding this comment.
can we add a comment about what this is doing - its kinda hard to understand
Comment on lines
21
to
29
| const getFormattedTime: string = (time: string) => { | ||
| const hours24 = parseInt(time.substring(0, 2)); | ||
| const hours = ((hours24 + 11) % 12) + 1; | ||
| const hoursText = hours < 10 ? "0" + hours.toString() : hours.toString(); | ||
| const amPm = hours24 > 11 ? " pm" : " am"; | ||
| const minutes = time.substring(3, 5); | ||
|
|
||
| return hoursText + ":" + minutes + amPm; | ||
| }; |
There was a problem hiding this comment.
just wondering, is there no better way to do this? this forces us to keep the exact same formatting through the entire app. Maybe luxon would help here? B/c now we have to make sure the formatting is correct
There was a problem hiding this comment.
Yes, I agree I think something like luxon is a cleaner option, which should also address your other comment. Added in new iteration
Anshul-Birla
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Administrative Info
Make sure your branch name conforms to:
<feature/staging/hotfix/...>/[username]/[Github Issue]-[3-4 word description separated by dashes].What issue(s) does this branch close?
#130
Changes
What changes did you make?
Testing
How did you confirm your changes worked?
Confirmation of Change
Upload a screenshot, if possible. Otherwise, please provide instructions on how to see the change.