Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/daniel vsr email #14

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Conversation

holychickencow
Copy link
Contributor

@holychickencow holychickencow commented Feb 1, 2024

Tracking Info

Resolves #12

Changes

  • Added automatic email function

Testing

  • Tested it with my personal email

Confirmation of Change

@holychickencow holychickencow changed the base branch from feature/steven+yoto-vsr-personal-info to main February 1, 2024 01:36
Copy link
Collaborator

@benjaminJohnson2204 benjaminJohnson2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Daniel, looks good to me! I made a few other changes to environment variables and cleaning up the testing script and some configuration files that accidentally got added to the PR

@benjaminJohnson2204 benjaminJohnson2204 requested review from Syu125, SamvritSrinath and HarshGurnani and removed request for Syu125 February 1, 2024 02:12
Copy link
Contributor

@HarshGurnani HarshGurnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good to me!

@SamvritSrinath
Copy link
Contributor

Looks good to me as well!
Uploading Screenshot 2024-02-13 at 3.38.12 PM.png…

@benjaminJohnson2204 benjaminJohnson2204 merged commit 70c48b6 into main Feb 14, 2024
4 checks passed
@benjaminJohnson2204 benjaminJohnson2204 deleted the feature/daniel-vsr-email branch February 14, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification Email to Staff upon VSR Submission
4 participants