-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/samvritsrinath firebase auth #18
Conversation
…g the intended function
… not being called
…go _id in route, currently only sending uid firebase auth fully functional, need to send mongo id in addition to firerbase UID from backend
merging with main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left a few minor comments but overall great job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more very minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing my comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - the dummy page showed up after login, and I can see the firebase errors when the login info is not in the database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Tracking Info
Resolves #8
Changes
user
mongo model withrole
anduid
fields/login
/api/whoami
that uses the sender's JWT token to verify identity, and returns the user's role and uid if that user exists in the database; this route is called upon hitting the login button on the frontendTesting
We added console statements that printed out the user information received from the backend, which we took a screenshot of in the Javascript console. Furthermore, a dummy page was set up that the login page routed to after the call to the backend was resolved. The page was also checked on a mobile device
Confirmation of Change