Feature/steven+yoto vsr personal info #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d martial to marital
…t end api requests imported and adjusted
…d a document to the mongo database
…, and continued styling
…, and continued styling
…b.com/TritonSE/PAP-Inventory-Processing into feature/steven+yoto-vsr-personal-info
benjaminJohnson2204
approved these changes
Feb 23, 2024
sydneyzhang18
approved these changes
Feb 24, 2024
holychickencow
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
For the most part it looks good, I have few notes that I'm not sure need to be fixed but I will leave it here case.
- You are allowed to be "single" but also have a spouse name.
- When you enter that you have 100 children, it states "This field must be a number no greater than 100," even though 100 should be valid.
Aside from these it looks good!
|
Thanks @holychickencow , nice catches! I just pushed some fixes to address your comments, we're good to merge now! |
benjaminJohnson2204
deleted the
feature/steven+yoto-vsr-personal-info
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #9
Changes
-Added a MongoDB schema for storing VSR form submissions
-Set up POST route for VSR
-Added front-end for submitting a VSR
-Added front-end side validation functions (currently unused)
Testing
-Front-end validation functions were tested using unit tests in frontend/tests
-Rest of the features were tested end-to-end:
-Load up both the front end and the back end
-Go to http://localhost:3000/vsr
-Leaving out any required field will result in the field failing to submit
-Providing invalid data, such as inputting strings for age, will result in an error from the back end.
-Submitting a valid form will have it show up in the MongoDB database
This was done various times, with different inputs and leaving different fields empty.
Note that MongoDB may take a few moments to update.
Confirmation of Change
Missing fields
Error upon invalid input
Successful form submission