Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter update #3

Merged
merged 16 commits into from
Jan 7, 2024
Merged

Linter update #3

merged 16 commits into from
Jan 7, 2024

Conversation

benjaminJohnson2204
Copy link
Collaborator

Changes

  • I updated the linters to use the new TSE linters, and added the secret scanning tool created by Justin.

Testing

  • I ran the project, lint checks, and secret scanner, and verified that they were working as desired. Specifically, I ensured that the .env.example file didn't trigger the secret scanner, and that adding an actual secret into our source code did trigger the scanner.

Confirmation of Change

  • Run the project, and it should still work fine. The secret scanner should complete without errors. If you add any of the real environment variable values from our .env file to the source code, then run the secret scanner, you can see that it detects the secret.

@benjaminJohnson2204 benjaminJohnson2204 merged commit ea369ec into main Jan 7, 2024
4 checks passed
@benjaminJohnson2204 benjaminJohnson2204 deleted the linter-update branch January 7, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant