Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/harsh daniel/vsr page 2 #30

Merged
merged 22 commits into from
Mar 19, 2024

Conversation

HarshGurnani
Copy link
Contributor

Tracking Info

Resolves #19

Changes

  • Added VSR Page 2 backend and frontend
  • Updated MongoDB, added new validators and controllers, and created second page form

Testing

  • Ran frontend and went to localhost:3000/vsr.

  • Can see created VSR form in MongoDB after hitting submit button

  • TODO

Confirmation of Change

image image
  • Run the frontend and go to localhost:3000/vsr. This should show both existing pages of the VSR form. Use the Next button after filling out the first page to see the second page.
  • After hitting Submit on the second page, check MongoDB for newly created VSR object

Copy link
Collaborator

@benjaminJohnson2204 benjaminJohnson2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I made a few minor changes but nice work overall, it works great!

Copy link
Contributor

@2s2e 2s2e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-I am able to submit an alphabetical phone number and a badly formatted email.
-Other than that everything looks good! Testing instructions work as expected, webpage looks aligned with figma, MongoDB works properly.

@HarshGurnani
Copy link
Contributor Author

Thanks @2s2e , I fixed the issues!

Copy link
Contributor

@sydneyzhang18 sydneyzhang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@benjaminJohnson2204 benjaminJohnson2204 merged commit 2839704 into main Mar 19, 2024
4 checks passed
@benjaminJohnson2204 benjaminJohnson2204 deleted the feature/harsh-daniel/vsr-page-2 branch March 19, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSR Form Page 2 - Contact Info, Military Background, and Additional Info
5 participants