Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/harsh steven/export vsr bulk #35

Merged
merged 36 commits into from
Apr 28, 2024

Conversation

2s2e
Copy link
Contributor

@2s2e 2s2e commented Apr 16, 2024

Tracking Info

Resolves #31

Changes

-Implemented export as pdf feature, which downloads a copy of all vsrs as an excel spreadsheet when the export button is clicked
-Added notifications for exporting VSR

Note: possible bug with furniture items

Testing

-We logged into the page as a privileged user, and clicked the export button. An excel file should then download, which contains the data for the VSRs. A success notification should also pop up

Confirmation of Change

image

image
(More columns to the right of the downloaded file)

Copy link
Collaborator

@benjaminJohnson2204 benjaminJohnson2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work guys! I used this PR to add a few minor unrelated changes & bugfixes. I'll assign 2 other reviewers in today's meeting.

Copy link
Contributor

@Syu125 Syu125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

Copy link
Contributor

@yotzkim yotzkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@benjaminJohnson2204 benjaminJohnson2204 merged commit 2a3c5c1 into main Apr 28, 2024
4 checks passed
@benjaminJohnson2204 benjaminJohnson2204 deleted the feature/harsh-steven/export-vsr-bulk branch April 28, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Bulk VSR Data to Spreadsheet
5 participants