-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/harsh steven/export vsr bulk #35
Feature/harsh steven/export vsr bulk #35
Conversation
…tonSE/PAP-Inventory-Processing into feature/harsh-steven/export-vsr-bulk
…of saving to disk (doesn't work on Vercel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work guys! I used this PR to add a few minor unrelated changes & bugfixes. I'll assign 2 other reviewers in today's meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Tracking Info
Resolves #31
Changes
-Implemented export as pdf feature, which downloads a copy of all vsrs as an excel spreadsheet when the export button is clicked
-Added notifications for exporting VSR
Note: possible bug with furniture items
Testing
-We logged into the page as a privileged user, and clicked the export button. An excel file should then download, which contains the data for the VSRs. A success notification should also pop up
Confirmation of Change
(More columns to the right of the downloaded file)