Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use Generic Type for Input Components #55

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Fix: Use Generic Type for Input Components #55

merged 1 commit into from
Feb 11, 2024

Conversation

aaronchan32
Copy link
Member

Changes

  • Added generic type support for input components

Testing

  • Tested previous StudentFormButton component. Data is logged in the console
  • Created simple example in frontend/src/pages/index.tsx demonstrating how the name prop for each input component should correspond to the form data type passed into the input component's corresponding useForm hook

*This example should be deleted before merging into main

Confirmation of Change

image

@aaronchan32 aaronchan32 requested a review from adhi0331 February 11, 2024 00:05
parth4apple
parth4apple approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@parth4apple parth4apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adhi0331
adhi0331 approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🚀

@adhi0331 adhi0331 merged commit 2c7c6ae into main Feb 11, 2024
2 checks passed
@adhi0331 adhi0331 deleted the feature/aaronchan32/input_field_component branch February 11, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhi0331 adhi0331 adhi0331 approved these changes

@parth4apple parth4apple parth4apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronchan32 @parth4apple @adhi0331