Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Protection for Profile Routes #88

Merged
merged 4 commits into from
Apr 13, 2024

Conversation

aaronchan32
Copy link
Member

Changes

  • Fixed bug where textfields without custom onChange logic would have a delay for their value. This can be tested by typing in a textfield and quickly pressing enter after to submit the form. The form's value will be empty if this is done too quickly
  • Added auth protection to all profile routes using verifyAuthToken middleware. Also attached userId to request if auth token is valid in backend/src/validators/auth.ts
  • Minor UI bug fixes

Testing

  • Ran through the same tests in PR 86

Copy link

Visit the preview URL for this PR (updated for commit bd6f99d):

https://pia-dev-60cea--pr88-feature-aaronchan32-2t38i6nb.web.app

(expires Fri, 19 Apr 2024 19:32:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b780ee12a240535f7ca0729d49968573a1f3e284

Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@adhi0331 adhi0331 merged commit b6d90d7 into main Apr 13, 2024
4 checks passed
@adhi0331 adhi0331 deleted the feature/aaronchan32/auth-protection-profile branch April 13, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants