Implemented admin checking and student counts on programs page #93
Conversation
|
Visit the preview URL for this PR (updated for commit bf3e2c2): https://pia-dev-60cea--pr93-feature-andrewzpu-pr-q2iz3a1t.web.app (expires Wed, 01 May 2024 18:47:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b780ee12a240535f7ca0729d49968573a1f3e284 |
| @@ -19,6 +21,10 @@ export default function Programs() { | |||
|
|
|||
| const [programs, setPrograms] = useState<ProgramMap>({}); | |||
|
|
|||
| const { firebaseUser, piaUser, loadingUser } = useContext(UserContext); | |||
| const _loadingUser = loadingUser; | |||
There was a problem hiding this comment.
I had it originally because I had an error for unused variable, but I don't think I need loadingUser anyways, so I'll remove that.
There was a problem hiding this comment.
ah gotcha, also I just put up a PR (#94) where I put isAdmin into the userContext so you could just grab that here if you want:
const { isAdmin } = useContext(UserContext);
There was a problem hiding this comment.
Once Parth's PR is in lets add that line so that we can maintain consistency.
frontend/src/pages/programs.tsx
Outdated
|
|
||
| export default function Programs() { | ||
| useRedirectToLoginIfNotSignedIn(); |
There was a problem hiding this comment.
i think they should be redirected to login if they are not signed in?
frontend/src/pages/programs.tsx
Outdated
|
|
||
| export default function Programs() { | ||
| useRedirectToLoginIfNotSignedIn(); |
| @@ -19,6 +21,10 @@ export default function Programs() { | |||
|
|
|||
| const [programs, setPrograms] = useState<ProgramMap>({}); | |||
|
|
|||
| const { firebaseUser, piaUser, loadingUser } = useContext(UserContext); | |||
| const _loadingUser = loadingUser; | |||
There was a problem hiding this comment.
Once Parth's PR is in lets add that line so that we can maintain consistency.
Tracking Info
Resolves #31
Part of #90
Changes
Added student counts to program cards in program page
Added admin checking to program page so certain features only appear for admins:
Testing
Ran website locally using our existing admin and non-admin accounts
Confirmation of Change
Admin view:
Team member view:
