-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for screenshots #70
Open
NateLanza
wants to merge
13
commits into
main
Choose a base branch
from
native-screenshot-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith one bug remaining Native screenshots are working, but the catpureNextRepaint() function doesn't yet capture the next repaint; it takes a screenshot before the next repaint
…to use functional approach ScreenshotStream now uses the functional approach that the rest of Trrack uses instead of OO/class based
Adds an API to the event registry allowing users to define whether actions should trigger screenshots and the associated delay. Adds an API to the trrack object for screenshots.
…eenshots available Also updates react-trrack-example to match
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API for taking screenshots of the current tab manually and when certain actions are trracked.
The
ScreenshotStream
interface defines an API for capturing screenshots. Screenshots are taken via theMediaDevices
API, specifically thegetDisplayMedia()
function. After starting a stream of frames from the browser, individual shots can be saved at any point, either manually or when triggering actions fire.The
Registry
API has been updated to add 2 fields:triggersScreenshot
, which defines whether an action should fire a screenshot, andtransitionTime
, which defines how long it takes for an action to be reflected in the visualization and therefore the delay before screenshotting.The
Trrack
object has been updated with a new field,screenshots
, an instance ofScreenshotStream
. This exposes methods for starting capture (necessary to obtain a stream of frames from the browser), which asks the user for permission to share the current tab. There are also methods to capture a screenshot immediately, capture after a delay, stop theMediaStream
that provides frames from the screenshare, and get saved screenshots. The current implementation of ScreenshotStream saves all captured screenshots to an array. The Trrack object does not take screenshots due to actions withtriggersScreenshot = true
until the ScreenshotStream has been started.