Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧚🏻 Remove goerli from example app multichain section #1157

Merged
merged 7 commits into from
May 14, 2024

Conversation

nezouse
Copy link
Member

@nezouse nezouse commented May 13, 2024

No description provided.

Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: f8268ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 13, 2024

@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 11:20 Inactive
Copy link
Contributor

github-actions bot commented May 13, 2024

@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 11:21 Inactive
Copy link
Contributor

github-actions bot commented May 13, 2024

@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 11:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 11:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 11:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 11:45 Inactive
@@ -18,6 +19,7 @@ import { getDefaultProvider } from '@ethersproject/providers'

const readOnlyUrls: Config['readOnlyUrls'] = {
[Mainnet.chainId]: process.env.MAINNET_URL || getDefaultProvider('mainnet'),
[Sepolia.chainId]: 'https://rpc.sepolia.org',
[Goerli.chainId]: process.env.MAINNET_URL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove it?

@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 12:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 12:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 12:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 12:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 12:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 12:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 12:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 12:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 12:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 13:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 13:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 13:37 Inactive
@nezouse nezouse merged commit b9113ed into master May 14, 2024
8 of 9 checks passed
@nezouse nezouse deleted the remove-goerli-from-example-app-multichain-section branch May 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants