Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: add code linter #219

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Ruby: add code linter #219

merged 9 commits into from
Dec 6, 2023

Conversation

kplattret
Copy link
Member

This introduces the use of Rubocop to ensure that the code-style is
consistent across the gem's source code. It also adds it as a CI step.

This introduces the use of Rubocop to ensure that the code-style is
consistent across the gem's source code. It also adds it as a CI step.
@kplattret kplattret requested a review from a team as a code owner November 29, 2023 18:31
@kplattret kplattret requested a review from a team November 29, 2023 18:31
@kplattret
Copy link
Member Author

I have also tested both the sign-request and webhook-server examples, and I can confirm they still work fine after these changes. 👍

Copy link
Contributor

@tl-flavio-barinas tl-flavio-barinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a ruby expert but LGTM

@kplattret kplattret merged commit c52706d into main Dec 6, 2023
4 checks passed
@kplattret kplattret deleted the ruby/add-linter branch December 6, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants