Skip to content

Commit

Permalink
Fixed failing type check in admin-x-design-system story (#20838)
Browse files Browse the repository at this point in the history
no issue

- The type checks for `admin-x-design-system` were failing for me locally for a Storybook story. It looks like we changed the `PopoverPosition` type to use 'start'/'end' rather than 'left'/'right', but this story was still using 'left'. This was causing `yarn test` to fail in the `admin-x-design-system` app.
- This commit updates the story to use 'start' instead of 'left', which allows the type checks to pass.
  • Loading branch information
cmraible authored Aug 28, 2024
1 parent 962194b commit a79ab03
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion apps/admin-x-design-system/src/global/SortMenu.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const Default: Story = {
items: items,
onSortChange: () => {},
onDirectionChange: () => {},
position: 'left'
position: 'start'
},
decorators: [
ThisStory => (
Expand Down

0 comments on commit a79ab03

Please sign in to comment.