Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tips & donations default suggested value #20793

Merged

Conversation

kevinansfield
Copy link
Member

closes https://linear.app/tryghost/issue/PLG-156

  • updated all default fixtures to use 500 ($5) as the default suggested donation value
  • added migration to update existing settings using the old default of 0 to 500
    • this is fine to apply because the feature hasn't been released so there's no explicit 0 values in the wild
  • added an acceptance test for the adminx-settings tips & donations section

@github-actions github-actions bot added the affects:admin Anything relating to Ghost Admin label Aug 20, 2024
Copy link
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@github-actions github-actions bot added the migration [pull request] Includes migration for review label Aug 20, 2024
@kevinansfield kevinansfield requested a review from sagzy August 20, 2024 10:34
closes https://linear.app/tryghost/issue/PLG-156

- updated all default fixtures to use `500` ($5) as the default suggested donation value
- added migration to update existing settings using the old default of `0` to `500`
  - this is fine to apply because the feature hasn't been released so there's no explicit `0` values in the wild
- added an acceptance test for the adminx-settings tips & donations section
@kevinansfield kevinansfield force-pushed the update-donations-default-value branch from 6478278 to 4e9d3d9 Compare August 20, 2024 10:40
Copy link
Contributor

@sagzy sagzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kevinansfield kevinansfield merged commit 0b3f7d7 into TryGhost:main Aug 20, 2024
22 checks passed
@kevinansfield kevinansfield deleted the update-donations-default-value branch August 20, 2024 11:07
kevinansfield added a commit to kevinansfield/Ghost that referenced this pull request Aug 20, 2024
ref TryGhost#20793

- now that there's a non-zero suggested value amount Stripe's UI shows a button to change the amount rather than showing the amount input field immediately
- added extra click to the tests and an expectation that the default value is set correctly
kevinansfield added a commit that referenced this pull request Aug 20, 2024
ref #20793

- now that there's a non-zero suggested value amount Stripe's UI shows a button to change the amount rather than showing the amount input field immediately
- added extra click to the tests and an expectation that the default value is set correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin migration [pull request] Includes migration for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants