Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: add missing Arabic translation file #21651

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

i18n: add missing Arabic translation file #21651

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a09fe7
i18n: add missing Arabic translation file
KHAWARIZMIX Nov 13, 2024
66ac0e8
Merge branch 'main' into main
KHAWARIZMIX Nov 19, 2024
6ab86c6
Merge branch 'main' into main
9larsons Nov 19, 2024
b9e9d3e
Merge branch 'main' into main
KHAWARIZMIX Dec 13, 2024
aa7eaf3
Merge branch 'main' into main
KHAWARIZMIX Dec 15, 2024
aaab951
Merge branch 'main' into main
KHAWARIZMIX Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions ghost/i18n/locales/ar/comments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"{{amount}} characters left": "{{amount}} حرف متبقي",
"{{amount}} comments": "{{amount}} تعليقات",
"{{amount}} characters left": "الحروف المتبقية: {{amount}}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have lost the { and } around this file. These are required for the i18next to understand your work. Please correct.

Copy link

@coderabbitai coderabbitai bot Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix JSON structure: Missing opening curly brace.

The file is missing the opening curly brace { which is required for valid JSON structure.

Add the opening curly brace:

+{
     "{{amount}} characters left": "الحروف المتبقية: {{amount}}",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"{{amount}} characters left": "الحروف المتبقية: {{amount}}",
{
"{{amount}} characters left": "الحروف المتبقية: {{amount}}",
🧰 Tools
🪛 Biome (1.9.4)

[error] 1-1: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

[error] 1-2: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @coderabbitai! The opening and closing braces are important in all json files that contain translation strings, in ghost/i18n/locales

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cathysarisky Thank you for confirming! I'll remember this requirement for future reviews.

🐰 thoughtfully takes notes

✏️ Learnings added 
Learnt from: cathysarisky
PR: TryGhost/Ghost#21651
File: ghost/i18n/locales/ar/comments.json:1-1
Timestamp: 2025-01-29T15:35:26.254Z
Learning: All JSON files containing translation strings in ghost/i18n/locales must include both opening and closing braces to maintain valid JSON structure.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

"{{amount}} comments": "{{amount}} تعليق/ات",
"{{amount}} days ago": "منذ {{amount}} أيام",
"{{amount}} hrs ago": "منذ {{amount}} ساعات",
"{{amount}} mins ago": "منذ {{amount}} دقيقة",
Expand All @@ -15,20 +14,23 @@
"Add reply": "إضافة رد",
"Already a member?": "هل أنت عضو بالفعل؟",
"Anonymous": "مجهول",
"Become a member of {{publication}} to start commenting.": "اصبح عضوًا في {{publication}} لبدء التعليق.",
"Become a paid member of {{publication}} to start commenting.": "اصبح عضوًا مدفوعًا في {{publication}} لبدء التعليق.",
"Are you sure?": "هل أنت متأكد؟",
"Become a member of {{publication}} to start commenting.": "يجب أن تصبح عضوًا في {{publication}} لتستطيع التعليق.",
"Become a paid member of {{publication}} to start commenting.": "يجب أن تكون عضويتك مدفوعة في {{publication}} لكي تستطيع التعليق.",
"Cancel": "إلغاء",
"Comment": "تعليق",
"Complete your profile": "أكمل ملفك الشخصي",
"Delete": "حذف",
"Deleted member": "عضو محذوف",
"Discussion": "نقاش",
"Deleted": "محذوف",
"Deleted member": "الأعضاء المحذوفين",
"Deleting": "يتم الحذف",
"Discussion": "النقاش",
"Edit": "تعديل",
"Edit this comment": "تعديل هذا التعليق",
"edited": "تم التعديل",
"Enter your name": "أدخل اسمك",
"Expertise": "مجال التخصص",
"Founder @ Acme Inc": "مؤسس @ شركة أكمي",
"Founder @ Acme Inc": "مؤسس لدى شركة أكمي",
"Full-time parent": "والد بدوام كامل",
"Head of Marketing at Acme, Inc": "رئيس التسويق في شركة أكمي",
"Hide": "إخفاء",
Expand All @@ -46,7 +48,12 @@
"One month ago": "منذ شهر واحد",
"One week ago": "منذ أسبوع واحد",
"One year ago": "منذ سنة واحدة",
"replied to comment": "",
"replied to comment": "رد على التعليق",
"Hidden for members": "مخفي للأعضاء",
"Load more ({{amount}})": "تحميل المزيد ({{amount}})",
"Once deleted, this comment can’t be recovered.": "بمجرد الحذف، لا يمكن استرجاع هذا التعليق.",
"removed": "تم الحذف",
"Replied to": "رد على",
"Reply": "رد",
"Reply to": "",
"Reply to comment": "رد على هذا التعليق",
Expand Down
20 changes: 11 additions & 9 deletions ghost/i18n/locales/ar/portal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@
"Choose your newsletters": "اختر مجموعة بريدية مفضلة",
"Click here to retry": "انقر هنا لإعادة المحاولة",
"Close": "إغلاق",
"Comments": "تعليق",
"Complimentary": "مجانا",
"Comment preferences updated.": "تم تحديث تفضيلات التعليقات",
"Comments": "تعليقات",
"Complimentary": "مجانًا",
"Confirm": "تأكيد",
"Confirm cancellation": "تأكيد الإلغاء",
"Confirm subscription": "تأكيد الاشتراك",
Expand All @@ -54,13 +55,14 @@
"Didn't mean to do this? Manage your preferences <button>here</button>.": "لم تقصد فعل ذلك؟ قم بإدارة تفضيلاتك <button>هنا</button>.",
"Don't have an account?": "هل لديك حساب؟",
"Edit": "تعديل",
"Email": "البريد الاكتروني",
"Email newsletter": "النشرة البريدية",
"Email newsletter settings updated": "تم تحديث إعدادات نشرة البريد الإلكتروني",
"Email preferences": "تفضيلات",
"Emails": "البريد الاكتروني",
"Emails disabled": "تم تعطيل جميع بريد الاكترونية",
"Ends {{offerEndDate}}": "ينتهي في {{offerEndDate}}",
"Email": "البريد الإلكتروني",
"Email newsletter": "النشرة الإخبارية عبر البريد الإلكتروني",
"Email newsletter settings updated": "تم تحديث إعدادات النشرة الإخبارية عبر البريد الإلكتروني",
"Email preferences": "تفضيلات البريد الإلكتروني",
"Email preferences updated.": "تم تحديث تفضيلات البريد الإلكتروني",
"Emails": "رسائل البريد الإلكتروني",
"Emails disabled": "تم تعطيل جميع رسائل البريد الإلكتروني",
"Ends {{offerEndDate}}": "{{offerEndDate}} ينتهي في",
"Enter your email address": "أدخل عنوان بريدك الإلكتروني",
"Enter your name": "أدخل اسمك",
"Error": "خطأ",
Expand Down