Updated/added Slovenian locale #22007
Conversation
WalkthroughThis pull request focuses on enhancing the Slovenian localization for the Ghost content management system. Multiple JSON files in the Changes
Possibly related PRs
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
ghost/i18n/locales/sl/newsletter.json (2)
2-2: Consider pluralization handling for authors.The translation "Avtor: {authors}" assumes singular form, but {authors} could contain multiple authors.
Consider using a conditional form:
-"By {authors}": "Avtor: {authors}", +"By {authors}": "Avtorji: {authors}",
4-4: Maintain consistency in translations.The word "brezplačno" is used for both "complimentary" and "free". While technically correct, consider using different terms to maintain nuance.
Consider using "brezplačno" for "free" and "promocijsko" for "complimentary" to better reflect the distinction.
Also applies to: 6-6
ghost/i18n/locales/sl/ghost.json (1)
24-24: Maintain consistency in exclamation marks.Notice the inconsistent use of exclamation marks between similar messages:
- "Thank you for subscribing to {{siteTitle}}." → "Hvala, ker ste se naročili na {{siteTitle}}!"
- "You're one tap away from subscribing to {{siteTitle}}!" → "Le en klik vas loči od tega, da se naročite na {{siteTitle}}!"
Consider maintaining consistent punctuation for similar message types.
Also applies to: 33-33
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
ghost/i18n/locales/sl/comments.json(1 hunks)ghost/i18n/locales/sl/ghost.json(2 hunks)ghost/i18n/locales/sl/newsletter.json(1 hunks)ghost/i18n/locales/sl/portal.json(1 hunks)ghost/i18n/locales/sl/search.json(1 hunks)ghost/i18n/locales/sl/signup-form.json(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- ghost/i18n/locales/sl/comments.json
- ghost/i18n/locales/sl/signup-form.json
- ghost/i18n/locales/sl/search.json
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: Unit tests (Node 20.11.1)
- GitHub Check: Unit tests (Node 18.12.1)
- GitHub Check: Regression tests (Node 20.11.1, sqlite3)
- GitHub Check: Regression tests (Node 20.11.1, mysql8)
- GitHub Check: Database tests (Node 20.11.1, sqlite3)
- GitHub Check: Lint
- GitHub Check: Database tests (Node 20.11.1, mysql8)
- GitHub Check: Database tests (Node 18.12.1, mysql8)
- GitHub Check: Ghost-CLI tests
🔇 Additional comments (6)
ghost/i18n/locales/sl/newsletter.json (1)
18-23: LGTM! Well-structured date-related messages.The translations for subscription-related messages maintain proper grammar structure and preserve all variables. The date handling is consistent across different contexts.
ghost/i18n/locales/sl/ghost.json (1)
3-7: LGTM! Consistent handling of action phrases.The translations for signup and confirmation actions maintain a consistent tone and proper use of the formal address form ("Potrdite", "Dokončajte").
ghost/i18n/locales/sl/portal.json (4)
13-13: LGTM! Proper phone number localization.The phone number format has been correctly adapted to Slovenian format (+386 12 345 678).
100-101: LGTM! Culturally appropriate name localization.The example name and email have been appropriately localized to "Janez Novak" and "[email protected]", which are common Slovenian examples.
173-178: LGTM! Consistent time-based messages.The translations for time-based error messages (days, hours, minutes) maintain proper grammar forms and number agreement.
162-162: Verify HTML button tag handling.The translations contain HTML button tags. Ensure the Ghost platform's translation system properly handles these HTML elements:
Also applies to: 203-203
✅ Verification successful
HTML button tags are consistently implemented across all translations
The button tags are present and consistently formatted across all 57 language translations in the portal.json files, indicating this is a supported and standardized feature of Ghost's translation system.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for other translations using HTML tags to verify consistency rg -l '<button>' ghost/i18n/locales/Length of output: 2126
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ghost/i18n/locales/sl/portal.json (1)
13-13: Adjust phone number format to match Slovenian standards.The phone number format should follow the standard Slovenian grouping: "+386 1 234 56 78" or "+386 12 345 678" depending on the area code length.
- "+1 (123) 456-7890": "+386 12 345 678", + "+1 (123) 456-7890": "+386 1 234 56 78",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
ghost/i18n/locales/sl/ghost.json(2 hunks)ghost/i18n/locales/sl/newsletter.json(1 hunks)ghost/i18n/locales/sl/portal.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- ghost/i18n/locales/sl/ghost.json
- ghost/i18n/locales/sl/newsletter.json
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: Ghost-CLI tests
- GitHub Check: Unit tests (Node 20.11.1)
- GitHub Check: Regression tests (Node 20.11.1, sqlite3)
- GitHub Check: Unit tests (Node 18.12.1)
- GitHub Check: Database tests (Node 20.11.1, sqlite3)
- GitHub Check: Regression tests (Node 20.11.1, mysql8)
- GitHub Check: Database tests (Node 20.11.1, mysql8)
- GitHub Check: Database tests (Node 18.12.1, mysql8)
- GitHub Check: Lint
🔇 Additional comments (6)
ghost/i18n/locales/sl/portal.json (6)
100-101: LGTM! Appropriate localization of example names and emails.The changes correctly adapt the example name and email address to the Slovenian context, using the proper TLD (.si) and common Slovenian name.
2-211: LGTM! Consistent terminology throughout the translations.Key terms are consistently translated throughout the file:
- "subscription" -> "naročnina"
- "account" -> "račun"
- "plan" -> "paket"
2-211: LGTM! Correct placeholder preservation and positioning.All variable placeholders ({{variable}}) are correctly preserved and positioned according to Slovenian grammar rules.
21-21: LGTM! Proper handling of HTML tags in translations.HTML tags are correctly preserved and positioned within the Slovenian translations, maintaining both functionality and natural language flow.
Also applies to: 55-55, 162-162
2-211: LGTM! Culturally appropriate translations.The translations maintain a consistent formal tone ("vi" form) appropriate for business communication in Slovenian, while correctly handling currency and numerical formats through variables.
2-211: LGTM! Proper handling of Slovenian special characters.All Slovenian special characters (č, š, ž) are properly encoded and used correctly throughout the translations.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ghost/i18n/locales/sl/portal.json (1)
203-203: Minor translation improvements suggestedConsider these refinements:
- Line 203: Fix typo "visljeno pošto" to "vsiljeno pošto"
- Line 208: Consider a more natural translation for "Your input helps shape what gets published." Perhaps: "Vaše mnenje nam pomaga pri izbiri objavljenih vsebin."
Also applies to: 208-208
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ghost/i18n/locales/sl/portal.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: Ghost-CLI tests
- GitHub Check: Unit tests (Node 20.11.1)
- GitHub Check: Unit tests (Node 18.12.1)
- GitHub Check: Regression tests (Node 20.11.1, sqlite3)
- GitHub Check: Regression tests (Node 20.11.1, mysql8)
- GitHub Check: Database tests (Node 20.11.1, sqlite3)
- GitHub Check: Database tests (Node 20.11.1, mysql8)
- GitHub Check: Database tests (Node 18.12.1, mysql8)
- GitHub Check: Lint
- GitHub Check: i18n
🔇 Additional comments (4)
ghost/i18n/locales/sl/portal.json (4)
1-212: JSON structure looks good!The file follows proper JSON formatting conventions with correct use of quotes, commas, and braces.
2-211: Placeholder variables are consistently maintained!All dynamic content placeholders (e.g., {{amount}}, {{name}}, {{price}}) are properly preserved in the translations, ensuring proper functionality.
13-13: Excellent cultural adaptations!Good attention to detail in adapting:
- Phone number format to Slovenian style (+386 1 234 56 78)
- Name example to a common Slovenian name (Janez Novak)
- Email example to use a Slovenian domain (primer.si)
Also applies to: 100-101
21-21: HTML elements are properly preserved!The translations correctly maintain HTML tags for formatting and links, ensuring the UI elements will function as expected.
Also applies to: 55-55, 162-162
Hey @coderabbitai , we don't actually care about the formatting on the phone number. No need to ask contributors to correct it in the future. Great job otherwise. |
|
Tip For best results, initiate chat on the files or code changes. @cathysarisky Thank you for the clarification. I understand now that phone number formatting standardization is not required in localization files. I'll keep this in mind for future reviews. ✏️ Learnings added
|
There was a problem hiding this comment.
General comment: Ghost generally tends towards informal language. I am NOT a Slovenian speaker, but I think you're using the formal forms here? I'll defer to your cultural knowledge about what's appropriate, but wanted to identify here that these translations are more formal in tone than what's in the English version.
Yes, I had doubts about this myself, but wanted to check first how it feels in emails, portal etc. and then correct later if necessary. I will take a look and correct where applicable. |
|
@martinverbic There's some conflicts here - once they're fixed we can merge this |
|
Thanks for notifying @allouis. I think they should be resolved now. |
Will update when I test out a Ghost instance in Slovenian extensively.