🎨 Added ability to vertically resize the Spam Filters text area

[evanwon]

• There's a clear use-case for this code change, explained below
• Commit message has a short title & references relevant issues
• The build will pass (run yarn test:all and yarn lint)

In Ghost Admin, the Spam Filters text area was not resizable, which made it difficult to work with for sites with more than 4 rows of blocked domains. This change makes the text area vertically resizable so, if desired, users can see more domains at the same time.

Before

The Spam Filters text area is not resizable, which makes it difficult to work with longer lists of spam domains.

After

Here's what the Spam Filters text area now looks like by default in Firefox - same size as before, but note the resize indicator in the bottom right corner.

And here's what it looks like when you manually resize the Spam Filters text area (note that it can only be resized vertically, which I think makes the most sense for this use case).

[coderabbitai]

Walkthrough

The changes in this pull request introduce a modification to the SpamFilters component within the admin-x-settings application. A new resize="vertical" property is added to the TextArea component used in the form for blocked email domains. This update enables users to resize the text area vertically, allowing for enhanced control over the input area's size. No changes were made to any exported or public entities, and the overall component structure and logic remain intact.

Possibly related PRs

• 🐛 Fixed tags and authors not fitting in the input field #22052: This PR involves similar changes by enhancing input fields to support dynamic vertical resizing, which aligns with the modifications introduced in this PR.

Suggested reviewers

• mike182uk

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/admin-x-settings/src/components/settings/advanced/SpamFilters.tsx

Oops! Something went wrong! :(

ESLint: 8.44.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/admin-x-settings".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/admin-x-settings/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fffd3e8 and aade804.

📒 Files selected for processing (1)

• apps/admin-x-settings/src/components/settings/advanced/SpamFilters.tsx (1 hunks)

🔇 Additional comments (1)

apps/admin-x-settings/src/components/settings/advanced/SpamFilters.tsx (1)

70-70: Great enhancement for user experience!

Adding the resize="vertical" prop to the TextArea component is an excellent improvement that directly addresses the usability issue mentioned in the PR objectives. This simple change will allow users to vertically expand the text area when managing large lists of blocked domains, making the interface much more user-friendly.

The implementation follows best practices by only modifying what needs to be changed, and works well with the existing fixed initial height (h-[86px]) that ensures a consistent default appearance.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sagzy]

Hello @evanwon,

Thanks for the PR! Makes sense :) Merging