Moved ActivityPub service to core package #22315
Conversation
WalkthroughThe pull request removes several configurations and source files related to the ActivityPub integration. In the Docker Compose file, a volume mapping for Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
daniellockyer
force-pushed
the
move-activitypub
branch
2 times, most recently
from
b8135d0 to
31477ee
Compare
fix https://linear.app/ghost/issue/ENG-2063/activitypub - this moves the AP service and test to the core package now we support TS in there - this allows us to start paring down the code we have, and relying on TS more - we can now also remove the activitypub package as it's no longer needed
- this file is no longer needed because we have bootstrapped the core repo with the ActivityPub TS code
daniellockyer
force-pushed
the
move-activitypub
branch
from
31477ee to
b65f1cc
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ghost/core/package.json (2)
223-223: Dependency Update: Added "node-fetch" Version 2.7.0The addition of
"node-fetch": "2.7.0"supports the refactor by replacing the previously externally maintained ActivityPub package. Please ensure that the new version is fully compatible with your usage (especially regarding differences in ESM support between v2 and later versions) and that all ActivityPub-related HTTP calls now rely on the local implementation in the core package.
61-235: Dependency Cleanup: Confirm Removal of "@tryghost/activitypub"According to the PR objectives, the dependency
"@tryghost/activitypub": "0.0.0"has been removed from the package. Please verify that no residual references to this package remain in the codebase or configuration files. This will help prevent unintended dependency bloat and potential conflicts in future builds.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (12)
compose.yml(0 hunks)ghost/activitypub/.eslintrc.js(0 hunks)ghost/activitypub/README.md(0 hunks)ghost/activitypub/package.json(0 hunks)ghost/activitypub/src/index.ts(0 hunks)ghost/activitypub/test/.eslintrc.js(0 hunks)ghost/activitypub/tsconfig.json(0 hunks)ghost/core/core/boot.js(0 hunks)ghost/core/core/demo.ts(0 hunks)ghost/core/core/server/services/activitypub/ActivityPubServiceWrapper.js(1 hunks)ghost/core/package.json(1 hunks)ghost/core/test/unit/server/services/activitypub/ActivityPubService.test.ts(1 hunks)
💤 Files with no reviewable changes (9)
- ghost/activitypub/src/index.ts
- ghost/core/core/demo.ts
- ghost/activitypub/.eslintrc.js
- ghost/core/core/boot.js
- ghost/activitypub/test/.eslintrc.js
- ghost/activitypub/package.json
- ghost/activitypub/README.md
- ghost/activitypub/tsconfig.json
- compose.yml
✅ Files skipped from review due to trivial changes (2)
- ghost/core/test/unit/server/services/activitypub/ActivityPubService.test.ts
- ghost/core/core/server/services/activitypub/ActivityPubServiceWrapper.js
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Setup
fix https://linear.app/ghost/issue/ENG-2063/activitypub