Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1655 Database.backup() typings #1656

Closed
wants to merge 7 commits into from
Closed

Conversation

benallfree
Copy link

@benallfree benallfree commented Nov 11, 2022

Here's a first cut at #1655. I have some questions:

  1. When, exactly, are each of the callback params called?
  2. Is Database.backup('foo.db', ()=>console.log('finished')) a complete example, or do step() and finish need to be called?

The docs say

The db.backup(filename, [callback]) shorthand is sufficient for making a backup of a database opened by node-sqlite3.

But later in the docs it says that step(-1) must be called.

Then it also says in different places that finish() is both required and not required.

Clearing up these ambiguities would help the dx.

@benallfree benallfree marked this pull request as draft November 12, 2022 07:19
@daniellockyer
Copy link
Member

Closing in favor of #1726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants