Skip to content

Commit

Permalink
Fixes Burrowers being able to use corrosive acid while underground (c…
Browse files Browse the repository at this point in the history
…mss13-devs#6348)

# About the pull request

Adds an extra check for being burrowed *after* the do_after in corrosive
acid.

Without this (how things are before this PR) it's possible to start
channeling the burrow ability and then start aciding an object, in which
case the acid will finish applying while you're underground since you've
already cleared the check for being burrowed.
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

Obviously unintended behavior and I *have* seen people in-game abusing
this.
It's quite awful to play against since there is absolutely zero
counterplay.
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

https://streamable.com/22ualc
</details>


# Changelog
:cl:
fix: Fixed an exploit that allowed Burrowers to apply acid to objects
while underground
/:cl:
  • Loading branch information
Tyranicranger4 authored May 30, 2024
1 parent 642e212 commit 681e522
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@
to_chat(src, SPAN_WARNING("[A] is already drenched in acid."))
return

if(HAS_TRAIT(src, TRAIT_ABILITY_BURROWED)) //Checked again to account for people trying to place acid while channeling the burrow ability
to_chat(src, SPAN_WARNING("We can't melt [O] from here!"))
return

if(!check_state())
return

Expand Down

0 comments on commit 681e522

Please sign in to comment.