-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a db management client for later job management #305
add a db management client for later job management #305
Conversation
required ResponseCode response_code = 1; | ||
} | ||
|
||
message ReadJobResultRequest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReadJobResult 换个名字
void DBManagementClient::DetectHeartbeat() { | ||
com::antgroup::tugraph::HeartbeatService_Stub& stub = | ||
DBManagementClient::GetInstance().GetHeartbeatStub(); | ||
while (true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
会死循环么?加个max retry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
心跳线程初始化之后就detach出去了,所以我理解应该是一直循环的吧?
return job_list; | ||
} else { | ||
DEBUG_LOG(ERROR) << "[READ JOB REQUEST]: " << cntl.ErrorText(); | ||
throw std::runtime_error("failed to connect to db management."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error最好都包一遍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
都包了
No description provided.