Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a db management client for later job management #305

Merged
merged 29 commits into from
Oct 24, 2023

Conversation

SonglinLyu
Copy link
Contributor

No description provided.

src/protobuf/tugraph_db_management.proto Outdated Show resolved Hide resolved
src/BuildLGraphServer.cmake Show resolved Hide resolved
src/server/db_management_client.cpp Outdated Show resolved Hide resolved
src/server/db_management_client.cpp Outdated Show resolved Hide resolved
src/server/db_management_client.cpp Outdated Show resolved Hide resolved
test/test_db_management_client.cpp Show resolved Hide resolved
test/test_db_management_client.cpp Show resolved Hide resolved
test/test_db_management_client.cpp Show resolved Hide resolved
src/protobuf/tugraph_db_management.proto Outdated Show resolved Hide resolved
required ResponseCode response_code = 1;
}

message ReadJobResultRequest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReadJobResult 换个名字

src/server/db_management_client.cpp Outdated Show resolved Hide resolved
void DBManagementClient::DetectHeartbeat() {
com::antgroup::tugraph::HeartbeatService_Stub& stub =
DBManagementClient::GetInstance().GetHeartbeatStub();
while (true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

会死循环么?加个max retry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

心跳线程初始化之后就detach出去了,所以我理解应该是一直循环的吧?

return job_list;
} else {
DEBUG_LOG(ERROR) << "[READ JOB REQUEST]: " << cntl.ErrorText();
throw std::runtime_error("failed to connect to db management.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error最好都包一遍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

都包了

src/server/db_management_client.h Show resolved Hide resolved
@qishipengqsp qishipengqsp merged commit fc00a1f into TuGraph-family:master Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants