fix #387: fix tls block #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options.cmake
Outdated
| @@ -48,7 +48,7 @@ endif (ENABLE_SQL_IO) | |||
| option(ENABLE_ASAN "Enable Address Sanitizer." OFF) | |||
| if (ENABLE_ASAN) | |||
| message("Address Sanitizer is enabled.") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -fno-omit-frame-pointer -static-libasan") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DENABLE_ASAN -fsanitize=address -fno-omit-frame-pointer -static-libasan") | |||
test/test_cpp_procedure.cpp
Outdated
| @@ -445,6 +452,23 @@ TEST_F(TestCppPlugin, CppPlugin) { | |||
| "#include <stdlib.h>", (plugin::CodeType)6, | |||
| "test", true, "v1")); | |||
| } | |||
| #ifndef ENABLE_ASAN | |||
There was a problem hiding this comment.
一般是#ifndef __SANITIZE_ADDRESS__
下面这里有内存问题？
There was a problem hiding this comment.
asan下dlclose并不会真正卸载动态库，这是asan一直就有的问题了：google/sanitizers#89
There was a problem hiding this comment.
我改成__SANITIZE_ADDRESS__吧
src/plugin/cpp_plugin.cpp
Outdated
| throw InternalError("Failed to unload library [{}].", name); | ||
| // using namespace lgraph::dll; | ||
| // PluginInfo* info = dynamic_cast<PluginInfo*>(pinfo); | ||
| // if (!UnloadDynamicLibrary(info->lib_handle)) |
| @@ -33,6 +33,41 @@ CppPluginManagerImpl::CppPluginManagerImpl(LightningGraph* db, const std::string | |||
|
|
|||
| CppPluginManagerImpl::~CppPluginManagerImpl() {} | |||
|
|
|||
| void CppPluginManagerImpl::OpenDynamicLib(const PluginInfoBase* pinfo, DynamicLibinfo &dinfo) { | |||
There was a problem hiding this comment.
文件头加点儿注释说明一下tls block的问题吧
|
fix #387 |
qishipengqsp
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix tls block