Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use PLUGIN_NAME_BASE_NAME in load_plugin_textdomain #28

Merged
merged 1 commit into from
Jul 31, 2023
Merged

use PLUGIN_NAME_BASE_NAME in load_plugin_textdomain #28

merged 1 commit into from
Jul 31, 2023

Conversation

luizbills
Copy link
Contributor

Signed-off-by: Luiz "Bills" [email protected]

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@luizbills
Copy link
Contributor Author

@smileBeda can you check this token error?

@smileBeda
Copy link
Member

smileBeda commented Aug 16, 2022 •
edited
Loading

@smileBeda can you check this token error?

Yes, I did already in another (older and one external) ticket
We can’t use this workflow anymore, it seems, not for forked PRs anyway - and I’ll have to remove it entirely from this flow.

I’ll do so soon… I still cannot believe that this is what is needed, but seems so.
I am thinking of a new flow to still use the Action (perhaps allow un-scanned PR into Develop, and then scan develop when merging to master)

@smileBeda smileBeda added this to the 4.1.0 milestone Aug 16, 2022
@smileBeda smileBeda added the enhancement New feature or request label Aug 16, 2022
@smileBeda smileBeda merged commit 0ad295e into TukuToi:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@luizbills @smileBeda