Bug fixed in seeyou.writer.Writer

[Brezinger]

multiple pics are only working when filenames are separated by semicolon instead of colon (Naviter cup file doc erroneous). Tested with LX9000 and Oudie

[bubeck]

https://downloads.naviter.com/docs/SeeYou_CUP_file_format.pdf says:

14 pics

A string field containing the filename(s) of an JPG image stored in pics/ folder of a seperate pics.zip file.
See SeeYou CUPX file format specification. Multiple filenames must be separated by commas and string must
be embraced in double quotes.

Does this means, that Oudie and LX9000 are not following the spec? Or is the spec wrong? Any other devices, where we know how they handle it?

[Brezinger]

I think that the spec is wrong. I am here in Gariep Dam and prepared a cupx file containing outlanding information utilizing aerofiles. I used the Google Maps API for downloading images of the landing strips at four different zoom levels. I prepared the cup file with aerofiles. Then I assembled the cup file and the downloaded images into a cupx file as described in the Naviter specs: https://downloads.naviter.com/docs/SeeYou_CUPX_file_format.pdf The first tests were performed on an LX 9000 system. It didn't work. Then I put only one picture (i.e. one zoom level) into the cup and cupx file. Then it worked. For further analysis, I reverse engineered (unpacked) an existing cupx file from the streckenflug.at outlanding database. And it had a semicolon separating the jpg filenames. I changed the format pics function of the aerofiles.seeyou.Writer class and assembled the cupx file with multiple images. This particular cupx file worked on Oudie 1, Oudie 2, LX 9000 and LX 9070 devices. So this are all very strong indications, that the Naviter spec is wrong. Best regards, Johannes Am Mi., 6. Dez. 2023 um 12:06 Uhr schrieb Dr. Tilmann Bubeck < ***@***.***>:

…

https://downloads.naviter.com/docs/SeeYou_CUP_file_format.pdf says: 14 pics A string field containing the filename(s) of an JPG image stored in pics/ folder of a seperate pics.zip file. See SeeYou CUPX file format specification. Multiple filenames must be separated by *commas* and string must be embraced in double quotes. Does this means, that Oudie and LX9000 are not following the spec? Or is the spec wrong? Any other devices, where we know how they handle it? — Reply to this email directly, view it on GitHub <#263 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHOULK24JUWSFUKZQRNXBQ3YIBGURAVCNFSM6AAAAABAJFUX3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGY2TKOBVGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[bubeck]

You are probably right, as XCSOar is also using ";":

https://github.com/XCSoar/XCSoar/blob/4234e2059a6a24959487f0b76a7675979db5a807/src/Waypoint/WaypointReaderSeeYou.cpp#L314

I will try to contact naviter to get an answer there. However, I assume, they approve you.
Could you please extend the PR so that the test succeed? Please make "make pytest" to execute the tests and change them to succeed.

[Brezinger]

I've already contacted them (Luka Salehar), and they approved that. Luka said, that they will update the specs accordingly. Will do the tests in the next few days. Am Mi., 6. Dez. 2023 um 15:23 Uhr schrieb Dr. Tilmann Bubeck < ***@***.***>:

…

You are probably right, as XCSOar is also using ";": https://github.com/XCSoar/XCSoar/blob/4234e2059a6a24959487f0b76a7675979db5a807/src/Waypoint/WaypointReaderSeeYou.cpp#L314 I will try to contact naviter to get an answer there. However, I assume, they approve you. Could you please extend the PR so that the test succeed? Please make "make pytest" to execute the tests and change them to succeed. — Reply to this email directly, view it on GitHub <#263 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHOULK27KHUAE4XTBWEGO4DYIB5UHAVCNFSM6AAAAABAJFUX3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSHE4DKNBVGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[bubeck]

Obsoleted by #266