Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DogeisCut/BeepBoxPlayer extension #1044

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

DogeisCut
Copy link

@DogeisCut DogeisCut commented Sep 18, 2023

Hello, I've created an extension to play Beepbox, Jummbox, Goldbox, and Ultraabox songs directly from the URL, or JSON. These are the blocks within the extension:
msedge_SzYsQOrk0e
msedge_bMMukP2VKb

This is the icon
beepBoxPlayerIcon

You may be concerned about the use of new Function() within the third-party code, it uses it to not have to branch on the number of voices while playing the song. The FM code does the same. The use of new Function() does not take user input nor has the potential to, and no variables leak into the global scope. I hope in this very specific case that use of new Function() is acceptable, especially since it is part of the third-party code and not my extension.

Also, I had to create a new pull request due to me messing with branches. Old pull request at #1042

Copy link
Contributor

@NexusKitten NexusKitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave the uses of fetch() and new Function() to Garbo as I'm not very experienced in that area, I don't imagine it being much of a vulnerability considering neither of them take user input but I'll wait for feedback from him.

Of course, the big problem with this extension is the fact that the entire BeepBox engine is stored inside of it, there's not much that can be done to get around that but see if you can find a way to minify it or something. Other than all that, nice extension, looking forward to playing around with it!

extensions/DogeisCut/BeepBoxPlayer.js Show resolved Hide resolved
extensions/DogeisCut/BeepBoxPlayer.js Show resolved Hide resolved
extensions/DogeisCut/BeepBoxPlayer.js Show resolved Hide resolved
extensions/DogeisCut/BeepBoxPlayer.js Show resolved Hide resolved
extensions/DogeisCut/BeepBoxPlayer.js Show resolved Hide resolved
@DogeisCut
Copy link
Author

Alright! Everything should be fixed and ready to go!

Policy on AI (ChatGPT, Bard, etc.) (TurboWarp#1035)
@DogeisCut
Copy link
Author

So uh...

@DogeisCut
Copy link
Author

man does this just happen to every extension

@CubesterYT
Copy link
Collaborator

@DogeisCut, what happens?

@DogeisCut
Copy link
Author

Maybe I'm just impatient or stupid but it seems a lot of extension just get ignored after a long time

@LilyMakesThings
Copy link
Contributor

LilyMakesThings commented Oct 30, 2023

They're not ignored, it's just that this is an open source project riding on the motivation of its sole, human-being manager

A lot of people have gotten very angry that people have lives, don't be one of those people!

@NexusKitten

This comment was marked as spam.

@NexusKitten

This comment was marked as spam.

@DogeisCut
Copy link
Author

DogeisCut commented Oct 30, 2023

Unfortunately, last I checked, my extension's license is compatible with MIT but can't use the MIT license due to the third-party code. That's okay for the TurboWarp gallery but not the PenguinMod one

@CubesterYT
Copy link
Collaborator

@DogeisCut, all we can say is, when it comes to open source development, there never is anything set in stone. When contributing, keep in mind things may happen instantly all the ways upward to taking months, maybe even a year from what I've seen, even in the most maintained and active scenario.

@DogeisCut
Copy link
Author

So... i noticed that other mods seem to be adding a similar thing... and it kind sucks that my thing is kinda left in the dust depsite being first........

@DogeisCut
Copy link
Author

Going to update this soon

@CubesterYT
Copy link
Collaborator

Later today, I'll do a review, add translation functions, and some other things, to prepare it for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants