Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension: Extendable Blocks #1254

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

CST1229
Copy link
Collaborator

@CST1229 CST1229 commented Jan 23, 2024

Blocks that extend, like in Snap!.
image

This uses a ton of scratch-blocks patches and also may be considered a utilities extension? (Though splitting this would require duplicating a bunch of code so...) So I don't know if this will be accepted or not.

@LilyMakesThings
Copy link
Contributor

I wouldn't consider this a Utilities extension because there is a consistent theme between each block - it also makes more practical sense to include these blocks into one extension because of the patches you're doing to ScratchBlocks.

@Skyhigh173
Copy link
Contributor

I think this icon is better than the current:
image

@CST1229
Copy link
Collaborator Author

CST1229 commented Jan 24, 2024

I think this icon is better than the current:

I prefer the current way of having the add input button being on the right and remove input being on the left for sure, but IDK about the icons themselves.

@fo-od
Copy link

fo-od commented Jan 28, 2024

i think having + and - icons would be better since you adding more/taking away, but it also makes sense to have arrows because the extension is called extendable blocks

@VoxelDoesCode
Copy link

The two arrows feel more in line with Scratch's design language, in my opinion.

@LilyMakesThings
Copy link
Contributor

LilyMakesThings commented Jan 28, 2024

The arrows came from the dropdown menus so they match the style, too.

Arrows are also more consistent with other familiar mods, such as Snap!.

@DilemmaGX
Copy link

image
I don't know why, but this extension cannot run on some versions of Turbowarp Desktop (for example, in this case, v1.9.3). Anyway, this extension is great running in turbowarp.org.

@CST1229
Copy link
Collaborator Author

CST1229 commented Feb 3, 2024

I don't know why, but this extension cannot run on some versions of Turbowarp Desktop (for example, in this case, v1.9.3).

Use the latest 1.10 beta; this extension requires some things that were only added in the merge-upstream update (the update which added color theme options and a bunch of addons).

@Gen1x-ALT
Copy link

this looks based

@DilemmaGX
Copy link

Hello, may I embed it into GekoWarp's extension library?

- tweak description
- remove MAX_EXTENDABLE_INPUTS (it's been a while)
- some code cleanup
@PPPDUD
Copy link

PPPDUD commented May 29, 2024

I haven't taken an in-depth review yet, but it looks interesting.

@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 14, 2024
@LSPECTRONIZTAR
Copy link

one prob: the json block will return 2 items even if there are more than 2 inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants