Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lily/Video -- Clamp Volume Between 0 and 1, & Add "get frame of video at (seconds)" #1595

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

SharkPool-SP
Copy link
Contributor

@SharkPool-SP SharkPool-SP commented Jul 8, 2024

Official PR from me, original: #1536

image

@LSPECTRONIZTAR
Copy link

PREACH 👏🏿👏🏿👏🏿

@Drago-Cuven
Copy link

pleeease merge.

@LSPECTRONIZTAR
Copy link

pleeease merge.

WHAT HE SAID
get garbo muffin in this one

@GarboMuffin
Copy link
Member

GarboMuffin commented Jul 12, 2024

is there a reason why we still want "get frame at time" with a forced 1 frame delay instead of "get frame at current time" that can return immediately?

@SharkPool-SP
Copy link
Contributor Author

is there a reason why we still want "get frame at time" with a forced 1 frame delay instead of "get frame at current time" that can return immediately?

How can you do that? The only thing I can think of is pre starting the video at the frame

@LSPECTRONIZTAR
Copy link

is there a reason why we still want "get frame at time" with a forced 1 frame delay instead of "get frame at current time" that can return immediately?

i thought it was fixed?

@CST1229
Copy link
Contributor

CST1229 commented Jul 12, 2024

How can you do that? The only thing I can think of is pre starting the video at the frame

the block currently seeks the video to a time then draws it to a canvas and returns the image. "get frame at current time" would just not seek and instead draw it and return immediately

@SharkPool-SP
Copy link
Contributor Author

How can you do that? The only thing I can think of is pre starting the video at the frame

the block currently seeks the video to a time then draws it to a canvas and returns the image. "get frame at current time" would just not seek and instead draw it and return immediately

Well I could add that as well @GarboMuffin . I personally think it's more tedious to get the frame of a video that's already currently playing. IMO people want this block so they can get another frame while the video is playing and so it doesn't add more blocks to the project...

@GarboMuffin
Copy link
Member

people want this block so they can get another frame while the video is playing

Ok but the current design is not good for that either because it will seek the video that is already playing just to get one frame out of it. Presumably people would then have to seek back to where it was before. And again, forced 1 frame delay.

@GarboMuffin
Copy link
Member

What do people want this for?

@LSPECTRONIZTAR
Copy link

What do people want this for?

i want it to display videos in a 3d scene for my 3d remake of osu! (which will be fire) and since there isn't a 3d rotate extension and just streching and resizing won't give the good effect I was gonna draw triangles with pen+

@GarboMuffin
Copy link
Member

I'm not sure how much this block would even help you

@LSPECTRONIZTAR
Copy link

I'm not sure how much this block would even help you

if only you could see what it was going to be like

@LSPECTRONIZTAR
Copy link

no video i guess

@GarboMuffin
Copy link
Member

GarboMuffin commented Jul 12, 2024

Converting the video to a URL with the extension as proposed is a forced 1 frame delay, and then converting that back to an actual image will be another forced 1 frame delay, nevermind whatever else you want to do with pen+, so the video could at best run at 50% of the project's framerate. really the only viable approach here is playing the video on a sprite using the blocks that are already there and asking for a way to apply arbitrary shaders/whatever onto a sprite

@LSPECTRONIZTAR
Copy link

playing the video on a sprite using the blocks that are already there and asking for a way to apply arbitrary shaders/whatever onto a sprite

I don't get it
and also the entire engine is drawn in one singular sprite, the game the environment everything

Copy link

@LSPECTRONIZTAR LSPECTRONIZTAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a great idea the frame 0.5x update is better than no update

@David-Orangemoon
Copy link
Contributor

Converting the video to a URL with the extension as proposed is a forced 1 frame delay, and then converting that back to an actual image will be another forced 1 frame delay, nevermind whatever else you want to do with pen+, so the video could at best run at 50% of the project's framerate. really the only viable approach here is playing the video on a sprite using the blocks that are already there and asking for a way to apply arbitrary shaders/whatever onto a sprite

There is a pen+ addon for that but it's not on the tw gallery due to it's nature being an addon to an extension.

@LSPECTRONIZTAR
Copy link

Converting the video to a URL with the extension as proposed is a forced 1 frame delay, and then converting that back to an actual image will be another forced 1 frame delay, nevermind whatever else you want to do with pen+, so the video could at best run at 50% of the project's framerate. really the only viable approach here is playing the video on a sprite using the blocks that are already there and asking for a way to apply arbitrary shaders/whatever onto a sprite

There is a pen+ addon for that but it's not on the tw gallery due to it's nature being an addon to an extension.

can i have the addon i really need it

@LSPECTRONIZTAR
Copy link

Hello

@GarboMuffin
Copy link
Member

image

@GarboMuffin GarboMuffin merged commit 532daff into TurboWarp:master Aug 6, 2024
3 checks passed
@Drago-Cuven
Copy link

Drago-Cuven commented Aug 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants