-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lily/Video -- Clamp Volume Between 0 and 1, & Add "get frame of video at (seconds)" #1595
Conversation
PREACH 👏🏿👏🏿👏🏿 |
pleeease merge. |
WHAT HE SAID |
is there a reason why we still want "get frame at time" with a forced 1 frame delay instead of "get frame at current time" that can return immediately? |
How can you do that? The only thing I can think of is pre starting the video at the frame |
i thought it was fixed? |
the block currently seeks the video to a time then draws it to a canvas and returns the image. "get frame at current time" would just not seek and instead draw it and return immediately |
Well I could add that as well @GarboMuffin . I personally think it's more tedious to get the frame of a video that's already currently playing. IMO people want this block so they can get another frame while the video is playing and so it doesn't add more blocks to the project... |
Ok but the current design is not good for that either because it will seek the video that is already playing just to get one frame out of it. Presumably people would then have to seek back to where it was before. And again, forced 1 frame delay. |
What do people want this for? |
i want it to display videos in a 3d scene for my 3d remake of osu! (which will be fire) and since there isn't a 3d rotate extension and just streching and resizing won't give the good effect I was gonna draw triangles with pen+ |
I'm not sure how much this block would even help you |
if only you could see what it was going to be like |
no video i guess |
Converting the video to a URL with the extension as proposed is a forced 1 frame delay, and then converting that back to an actual image will be another forced 1 frame delay, nevermind whatever else you want to do with pen+, so the video could at best run at 50% of the project's framerate. really the only viable approach here is playing the video on a sprite using the blocks that are already there and asking for a way to apply arbitrary shaders/whatever onto a sprite |
I don't get it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a great idea the frame 0.5x update is better than no update
There is a pen+ addon for that but it's not on the tw gallery due to it's nature being an addon to an extension. |
can i have the addon i really need it |
Hello |
Garbo, this is really helpful for any sort of 3d scene, pen usage, and
could possibly even enable pen+ shader overlay (assuming it's not already a
thing.) This allows for all sorts of innovative creations and even I intend
to use this when merged. At some point I already stated before, if this
isn't merged I'd literally download the js file and use it over the
original myself. It's THAT useful.
That being said, I do agree there should also be a get frame at current
time to avoid that extra frametime.
…On Fri, Jul 12, 2024, 3:30 PM Muffin ***@***.***> wrote:
I'm not sure how much this block would even help you
—
Reply to this email directly, view it on GitHub
<#1595 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANYWUKNTQ46VYEQH3KPY25TZMA4FBAVCNFSM6AAAAABKQBRGL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWGMYDSNRWGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Official PR from me, original: #1536