Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden "ArrayBuffer" option (for ZIP) #1633

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yuri-kiss
Copy link
Member

This adds a hidden arrayBuffer option to the menu which can be enabled by setting "_showArrayBufferOption" to true. (its meant for other extensions to do it)

I am making a buffer extension and wanna PR it, but the current method to add support is 6KB of patch code so I wanted to do it internally.

@CST1229
Copy link
Collaborator

CST1229 commented Jul 29, 2024

i expected this to be in the same pr as the buffer extension itself

@yuri-kiss
Copy link
Member Author

i expected this to be in the same pr as the buffer extension itself

🫠

@CST1229
Copy link
Collaborator

CST1229 commented Jul 29, 2024

but ok

@yuri-kiss
Copy link
Member Author

but ok

I mean I can close this and move it with the buffer ext if you want :I

@yuri-kiss yuri-kiss mentioned this pull request Jul 30, 2024
@GarboMuffin GarboMuffin added the pr: change existing extension Pull requests that change an existing extension label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants