cursor: translate cursor menu #2076
Conversation
SharkPool-SP
changed the title
github-actions
bot
added
the
pr: change existing extension
SharkPool-SP
changed the title
There was a problem hiding this comment.
If you are going to do this preferably add an index for each item like native scratch, so people who dont know english (or the right value cause you changed the naming) can still use the block effectively.
that or we need to make a new block and use a field instead
done |
|
!format |
|
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files. |
|
GarboMuffin in #1987:
The current names are meant to parody those used in the CSS "cursor" attribute. These names are not localized to any language except English, and so there's not really a reason to translate them unless we plan to change the names to make them more descriptive. I don't see anything wrong with doing so. |
|
before doing that, as their is obviously conflicting opinions, can you consult with the other people... |
im fine with no numbers |
that isnt the point. there are other reviewers on this team besides just you and garbomuffin... and this is already a precedence set by scratchfoundation for their translated accept reporters menus.. which this so keenly breaks on purpose now; with no consultation to anyone else before hand in which the PR is involved. |
No other reviewers voiced a concern for numbers. Additionally, no other extension in the TW gallery follows that number format. Sure get the other's opinions, but there doesnt seem to be a point |
"this is already a precedence set by scratchfoundation" there is a point, you are choosing to ignore it. further talk on this subject was done in the discord: https://discord.com/channels/837024174865776680/1147654296926687242/1321630894204649502 |
|
We already have many extensions that have translatable menus without a number fallback or equivalent: Animated Text (when enabling features incompatible with Scratch Lab), Files, Pointer lock, Runtime options, Text, Clipping and blending, Iframe, Pen+ V7, Skins, Sensing+, Key simulation, Mobile keyboard, I stopped looking but there are lots more Merging this without numbers also does not preclude the future possibility of adding numbers |
|
Feel free to revert my commit and make the numbers actually work though. I'll approve that |
GarboMuffin
changed the title
|
!format |
Resolves: #1987
I changed some naming or cursors, lmk if some others should be changed as well...