added http request ext #458
Conversation
extensions/godslayerakp/http.js
Outdated
| const instance = new WebRequests(); | ||
| Scratch.extensions.register(instance); | ||
| // @ts-ignore | ||
| runtime.ext_http = instance; |
There was a problem hiding this comment.
you shouldn't need to do that
There was a problem hiding this comment.
is there a good reason those extra blocks can't just be in the extension? there is no precedent for an extension to require another one to be used first
There was a problem hiding this comment.
is there a good reason those extra blocks can't just be in the extension? there is no precedent for an extension to require another one to be used first
yes and no, i put them separately becuase they look ugly and dont rlly fit well into the main extension imo
There was a problem hiding this comment.
reading it again i noticed you specified "required", they are not meant to be required and for the most part are not
There was a problem hiding this comment.
it seems to me that every block in httpExtra uses ext_http, so yes it is a required dependency
There was a problem hiding this comment.
it seems to me that every block in httpExtra uses ext_http, so yes it is a required dependency
oh you meant the other way
i was reading it as http requiring httpExtra
|
and now its broken :/ |
|
thanks for your patience does httpExtra do anything that isn't possible with other JSON extensions here? if it does, is there a good reason we can't just put them in the main extension? perhaps using a button to hide them by default, but it doesn't look like there's too many there anyways |
yes it does do more then what json can as it manualy edits the whole request options object |
|
thank you for your patience |
No description provided.