Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VectorUtils and SDF #474

Closed
wants to merge 61 commits into from
Closed

Conversation

4leph0mega
Copy link

It adds functionality on 3D vectors more easily

@4leph0mega 4leph0mega changed the title VectorUtils extension i made Add VectorUtils May 30, 2023
@4leph0mega 4leph0mega closed this May 30, 2023
@4leph0mega 4leph0mega reopened this May 30, 2023
@LilyMakesThings
Copy link
Contributor

LilyMakesThings commented Jun 13, 2023

The blocks don't have any error handling, so every single block stalls if you click it in the palette (except the 2 blocks in the image).
image
image

@GarboMuffin GarboMuffin changed the title Add VectorUtils Add VectorUtils and SDF Jun 30, 2023
@GarboMuffin
Copy link
Member

thank you for your patience

if you still would like this to be added, I would like to see:

  • improved error handling for invalid JSON (I bet you can find a more compact way yo represent the vectors too)
  • resolve all ESLint errors in the checks at the bottom of these comments (warnings are okay; I can resolve those myself later)
  • may help to clarify what an SDF is
  • the default values in the blocks should ideally demonstrate the block somehow, at least not throw errors

@4leph0mega
Copy link
Author

thanks for the feedback, i dont really have much free time to work on it currently but i will try to do it

@GarboMuffin
Copy link
Member

Sorry for the delay

I am closing this in favor of #779 which seems to have the same vector utilities

If you are still interested in getting the SDF extension in then please let me know

@GarboMuffin
Copy link
Member

Actually, I'll leave this open, but only for the SDF extension

@GarboMuffin GarboMuffin reopened this Aug 25, 2023
@GarboMuffin
Copy link
Member

sorry, SDFs has some issues

if you're interested in continuing with this, please let me know, but i do need to clear things out of the pull request queue if they are abandoned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants